swaps are showing as failed on taker when watcher completed it

[cipig]

During watcher testing, we found out that the swaps finished by the watcher are marked as failed and recoverable on taker after he goes back online.
The test was done by killing mm2 on taker after he sent takerpayment.
The watcher completed the swap later:
27 06:17:33, mm2_main::mm2::lp_swap::swap_watcher:416] INFO Maker payment spend sent: Maker payment spend tx a3a3403e35beb13ffb319c320c95cf758aad876656c3c2a2f591d4833a596f4e sent by watcher

Restarted taker after that and saw that i had the funds, but the swap was marked failed and recoverable. The recover fails of course, since watcher already sent makerpayment to taker.

This is the swap JSON from taker:
abd9ec38-6607-49c0-8468-281173f8bdd4.json.txt

[caglaryucekaya]

@cipig How long after did you restart the taker?

[cipig]

@cipig How long after did you restart the taker?

That is a good question, i guess a couple hours, but can't tell for sure. Does it make a difference?

[caglaryucekaya]

Yeah also from the timestamps it looks like a few hours later. I wanted to understand why the swap failed in your case because when I try to reproduce the bug the taker just sends the MakerPaymentSpend transaction a second time after the watcher and completes the swap as successful. It failed in your case because the locktime was passed. No it doesn't make a difference since the problem is that the taker shouldn't start the swap again if the watcher already completed it.

[cipig]

i wanted to test the new watcher thing, so i started a swap and killed the taker after he sent takerpayment... so taker can't complete the swap, since it was not running any more