Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): fix regex parsing passphrase from .env file #1931

Merged
merged 9 commits into from
Sep 8, 2023
Merged

fix(tests): fix regex parsing passphrase from .env file #1931

merged 9 commits into from
Sep 8, 2023

Conversation

dimxy
Copy link
Collaborator

@dimxy dimxy commented Aug 3, 2023

Fix regex to parse passphrase from .env file if newline char added

@dimxy dimxy changed the title fix(tests) fix regex parsing passphrase from .env file fix(tests): fix regex parsing passphrase from .env file Aug 3, 2023
shamardy
shamardy reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for discovering this issue and fixing it :)
Only one comment from my side

mm2src/mm2_test_helpers/src/for_tests.rs Outdated Show resolved Hide resolved
@dimxy dimxy assigned dimxy and shamardy and unassigned shamardy and dimxy Aug 11, 2023
@shamardy shamardy added in progress Changes will be made from the author and removed under review labels Aug 17, 2023
@dimxy
Copy link
Collaborator Author

dimxy commented Sep 7, 2023

I fixed regex back so only XXX_PASSPHASE var pattern is parsed now (like it is in .env.client and .env.seed).
Also I fixed some tests to always use .env.client for ALICE and .env.seed for BOB. (As parsing of env files was broken it was not an issue. But when parsing is fixed we must use proper files in tests.)

@dimxy dimxy added under review and removed in progress Changes will be made from the author labels Sep 8, 2023
shamardy
shamardy previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the documentations as well :)

@shamardy shamardy merged commit 50acc0e into dev Sep 8, 2023
27 of 31 checks passed
@shamardy shamardy deleted the bugfix-parse-env-file branch September 8, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

Assignees

@dimxy dimxy

Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimxy @shamardy