Use env variables for mm2 / RPC #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 environment variables:
DEX_APIwhich names the api binary. Normally launching the app includes akillall mm2. If we use a different filename for whitelabels, launching a whitelabel will not kill a different whitelabel's mm2 instance - e.g. if running AtomicDEX, launching SmartDEX will not kill the AtomicDEX mm2 instanceDEX_RPCPORTdefines different RPC ports for a whitelabel's mm2, so there is no port conflict while running other whitelabels.DEX_RPCis the full RPC url with port for mm2.clientTo test: Simply make sure it launches and can swap. There should be no change to app functionality.
In future similar PR to whitelabels, test will be launch and do swap between whitelabel and atomicdex running on same machine at same time.