-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add form shortcuts, min vol input #1944
Conversation
Thats a great feature, thank you!
Screen.Recording.2022-08-25.at.14.45.14.mov
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ it worth to double-check calculations, seems to be not precise
At the moment, the +1% is relative to currently input price, so it is compounding. The only problem with this is if the coin has no cex price to calculate from. In this case, I can revert to compounding relative to price input field. |
It depends on how these buttons should act: 0% button now setting price same as CEX, if -1% and +1% operating with price in field it's a bit inconsistent/confusing imo (at least without additional clarification for the user, e.g. I've expected that -1% +1% setting price 1% better or worse vs CEX price) |
non-compounding is more intuitive, tho with tooltip explaining the compounding way for both priced and unpriced would be more consistent (otherwise long tooltip with conditionals). Another alternative could be to remove those buttons for unpriced pairs (right now clicking the zero on an unpriced coin is pointless) |
maybe we should use both? (don't show buttons for assets without CEX price and in case if they showing show a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smk762 this tip is a good idea, but they covered the field with information. So to see how the amount changed in this field I need to move out the mouse every time. Can you please replace the tips on the bottom of the buttons? I hope it will be better
I can set a negative price if I enter 0 and click the -1 button
Anyway, this swap will fail because of minimum price( [{"error":"rpc:212] dispatcher_legacy:160] lp_ordermatch:3565] lp_ordermatch:3646] Price is too low, minimum is 0.00000001"}]
). But I guess it would be good to eliminate the possibility of setting a negative value
atomic_defi_design/Dex/Exchange/ProView/PlaceOrderForm/OrderForm.qml
Outdated
Show resolved
Hide resolved
found a bug I think: Screen.Recording.2022-08-31.at.17.45.24.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great to fix ^^
I've also made the form stop bouncing around when you toggle the min volume field, get an error message or the "Order selected" box is displayed. Previously, when these became visible, it would shift other form elements - now everything should stay where it is when these things change between visible or hidden. |
closes: #1941
closes: #1459
orderform_update.mp4