Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore default coins json if user json invalid #1967

Merged
merged 1 commit into from
Sep 27, 2022
Merged

restore default coins json if user json invalid #1967

merged 1 commit into from
Sep 27, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 13, 2022

Closes: #1966

To test:

  • Edit your coins json file so it is invalid (e.g. delete some " or , or })
  • Launch app, should be able to log in without crash, and see default coins enabled.

@smk762
Copy link
Collaborator Author

smk762 commented Sep 13, 2022

closing, combined with #1632

@smk762 smk762 closed this Sep 13, 2022
@smk762 smk762 reopened this Sep 23, 2022
@smk762
Copy link
Collaborator Author

smk762 commented Sep 23, 2022

this is probably worth having in next release even if #1632 is not ready yet.

@smk762 smk762 requested review from Canialon, SirSevenG and a user September 23, 2022 16:12
@SirSevenG
Copy link
Contributor

Works for me.
Broke coins-config file, app started with default config for the wallet with no issues.

Not sure if we should notify user why their coins list was reset. This is an unlikely case for normal app updates.

@smk762 smk762 merged commit 88ce3e6 into dev Sep 27, 2022
@smk762 smk762 deleted the coin_crash branch August 7, 2023 07:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: App crash on login if coins file corrupted
3 participants