Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notif not updated on lang change #2106

Merged
3 commits merged into from
Nov 25, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2022

Closes #2086

Please test every events handled by the NotificationsManager:
Capture d’écran 2022-11-24 à 4 33 00 PM

Please note that onBatchFailed and onMismatchCustomCoinConfiguration are never triggered from the backend (we should remove them?) and are therefore not testable atm.

@smk762
Copy link
Collaborator

smk762 commented Nov 24, 2022

Unless we have need for them, cleaning it out is probably a good idea.
onMismatchCustomCoinConfiguration shouldn't happen anyway and if/when we implement #2103 it won't.

@ghost ghost mentioned this pull request Nov 24, 2022
@smk762
Copy link
Collaborator

smk762 commented Nov 25, 2022

  • updateSwapStatus
  • balanceUpdateStatus
  • enablingZcoinStatus
  • enablingCoinFailedStatus
  • disablingCoinFailedStatus
  • endpointNonReachableStatus

enablingZcoinStatus and disablingCoinFailedStatus seems to be in English regardless of chosen language, probably it needs translations file updates.

@ghost
Copy link
Author

ghost commented Nov 25, 2022

enablingZcoinStatus and disablingCoinFailedStatus seems to be in English regardless of chosen language, probably it needs translations file updates.

Yeah translations are unfinished

Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code and indeed we are missing translations for the title of those notifications (for zhtlc body text like ActivatingCoin this is direct from API so it is not in the .ts files).

These translation fixes can be addressed in a separate PR. We can probably get rid of the zhtlc enabling notifications too, this is communicated adequately by % in GUI. Can do that in https://github.com/KomodoPlatform/atomicDEX-Desktop/pull/2097/files

@ghost ghost merged commit 04edb6d into dev Nov 25, 2022
@smk762 smk762 mentioned this pull request Mar 6, 2023
@smk762 smk762 deleted the fix_notif_no_updated_on_lang_change branch August 7, 2023 07:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: Notifications do not change language on locale switch
2 participants