-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notif not updated on lang change #2106
Conversation
Unless we have need for them, cleaning it out is probably a good idea. |
|
Yeah translations are unfinished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code and indeed we are missing translations for the title of those notifications (for zhtlc body text like ActivatingCoin
this is direct from API so it is not in the .ts files).
These translation fixes can be addressed in a separate PR. We can probably get rid of the zhtlc enabling notifications too, this is communicated adequately by % in GUI. Can do that in https://github.com/KomodoPlatform/atomicDEX-Desktop/pull/2097/files
Closes #2086
Please test every events handled by the NotificationsManager:
Please note that
onBatchFailed
andonMismatchCustomCoinConfiguration
are never triggered from the backend (we should remove them?) and are therefore not testable atm.