Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm modal translations #2132

Merged
merged 8 commits into from
Dec 4, 2022
Merged

Confirm modal translations #2132

merged 8 commits into from
Dec 4, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 30, 2022

Closes: #2131

@smk762 smk762 marked this pull request as draft November 30, 2022 08:30
@smk762
Copy link
Collaborator Author

smk762 commented Nov 30, 2022

cc: PTYX @SylEze @SirSevenG @ozkanonur can you please assist with native translations for the fee details labels and error warning in the attached issue?

Taker tx fee
Dex tx fee
Dex fee
Maker tx fee
Total COIN fees
dPoW protected
Trade price is more than 50% different to CEX! Confirm?

@onur-ozkan
Copy link
Member

% comes before the number in Turkish standards. So not value % but % value. Rather than that looks correct.

@smk762
Copy link
Collaborator Author

smk762 commented Nov 30, 2022

Thanks! There's still a couple of English bits, can you please assist with those?

dPoW protected
Trade price is more than 50% different to CEX! Confirm?

@onur-ozkan
Copy link
Member

onur-ozkan commented Nov 30, 2022

Thanks! There's still a couple of English bits, can you please assist with those?

dPoW protected
Trade price is more than 50% different to CEX! Confirm?
  • dPoW korumalı
  • Takas ücreti CEX ile karşılaştırıldığında %50'den daha fazla farka sahip. Onaylıyor musunuz?

@smk762
Copy link
Collaborator Author

smk762 commented Dec 1, 2022

@SirSevenG Please assist with the required translations to complete the window below:
image

@smk762
Copy link
Collaborator Author

smk762 commented Dec 1, 2022

@SylEze Please assist with completion of the translations in the window below
image

@SirSevenG
Copy link
Contributor

SirSevenG commented Dec 2, 2022

@SirSevenG Please assist with the required translations to complete the window below:

I would suggest to leave fees as is,

Total COIN fees
Суммарная комиссия COIN -- can also leave as is

dPoW protected
dPoW защита

Trade price is more than 50% different to CEX! Confirm?
Стоимость обмена в сравнении с CEX дороже более чем на 50%, вы подтверждаете сделку?

@smk762
Copy link
Collaborator Author

smk762 commented Dec 2, 2022

Russian ✔️
image

German ✔️
image

Spanish ✔️
image

Turkish ✔️
image

English ✔️
image

French ⏳
image

@smk762
Copy link
Collaborator Author

smk762 commented Dec 2, 2022

cc: @SylEze ^

@smk762 smk762 self-assigned this Dec 2, 2022
@smk762 smk762 requested review from a user, Canialon, cipig and SirSevenG December 2, 2022 11:49
@smk762 smk762 marked this pull request as ready for review December 2, 2022 11:49
@smk762 smk762 merged commit 5511d63 into dev Dec 4, 2022
@smk762 smk762 deleted the fix_ts branch December 4, 2022 16:20
@smk762 smk762 mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Trade confirmation modal views broken by translations
5 participants