Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit warning text values to 8dp #2178

Merged
1 commit merged into from
Dec 12, 2022
Merged

limit warning text values to 8dp #2178

1 commit merged into from
Dec 12, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 11, 2022 •
edited
Loading

closes #2177

To test:

  • simulate case where low balance error happens in pro view (you can do this by broadcasting a withdrawal in CLI using the app RPC credentials, then trying to do a swap soon after)

@smk762 smk762 requested review from a user, cipig, SirSevenG and Canialon December 11, 2022 10:46
cipig
cipig approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ghost ghost merged commit c998372 into dev Dec 12, 2022
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
@smk762 smk762 deleted the warning_overflow branch August 7, 2023 07:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@SirSevenG SirSevenG Awaiting requested review from SirSevenG

@Canialon Canialon Awaiting requested review from Canialon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Order form warning message overflow
2 participants
@smk762 @cipig