Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source coin icons before make for windows #2218

Merged
merged 1 commit into from
Mar 6, 2023
Merged

source coin icons before make for windows #2218

merged 1 commit into from
Mar 6, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 4, 2023 •
edited
Loading

The way the CI runs, Linux and Mac use ./ci_tools_atomic_dex (nim), and windows does not. Since #2194 this has led to missing coin icons in Windows builds.

To test:

SirSevenG
SirSevenG approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are back

Canialon
Canialon approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can see all icons 🎉

@smk762 smk762 merged commit 7612e63 into dev Mar 6, 2023
@smk762 smk762 deleted the restore_win_coins branch March 6, 2023 10:23
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirSevenG SirSevenG SirSevenG approved these changes

@Canialon Canialon Canialon approved these changes

@cipig cipig Awaiting requested review from cipig

@endrilickollari endrilickollari Awaiting requested review from endrilickollari

@gcharang gcharang Awaiting requested review from gcharang

@tonymorony tonymorony Awaiting requested review from tonymorony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smk762 @SirSevenG @Canialon