Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show trade volume for pair under pro orderbook #2383

Merged
merged 16 commits into from
Dec 5, 2023
Merged

Show trade volume for pair under pro orderbook #2383

merged 16 commits into from
Dec 5, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 5, 2023

Closes #2382 and #2384
image

To test:

  • Confirm pairs match values at https://defi-stats.komodo.earth/api/v3/gecko/tickers
  • Confirm reverse pair shows same values
  • Confirm segwit / non-segwit pairs show same values
  • If pair not in list on API, or zero volume traded, volume text should not display
  • Confirm values update on fiat settings change as expected.
  • Confirm pro view combo box text changes as expected when changing currency via menubar

@kivqa
Copy link

kivqa commented Nov 6, 2023

@smk762 trade volume works only for USD currency. If I use any other currency volume is zero
e.g. GBP
image

@smk762
Copy link
Collaborator Author

smk762 commented Nov 7, 2023

@smk762 trade volume works only for USD currency. If I use any other currency volume is zero e.g. GBP image

Should be fixed now

fiats.mp4

Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Trade volume displayed correctly for different pairs and its matching with API response.
Changing currency in the app now handled correctly for trading volume.
There is not translation but its better to fix in separate issues with other places without translation.

@smk762 smk762 merged commit e85f7ef into dev Dec 5, 2023
5 of 8 checks passed
This was referenced Dec 20, 2023
@smk762 smk762 deleted the show-stats branch January 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Show 24hr trade volume for pairs
3 participants