Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce high Tendermint fees #2386

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Reduce high Tendermint fees #2386

merged 6 commits into from
Dec 13, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 10, 2023

Solves #2371 until an API level solution is available.
To Test:

  • try sending Tendermint assets (ATOM, IRIS, OSMO, ATOM-IRIS_IBC) without custom fee.
  • try sending Tendermint assets (ATOM, IRIS, OSMO, ATOM-IRIS_IBC) with custom fee.

IRIS seemed to be the first to reject the tx when static fee was reduced further. The following values should work for custom fees for all Tendermint coins:

  • gas_price: 0.05
  • gas_limit: 150000

Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifying custom fees for sending an IRIS tx works fine
when i use the values mentioned in this PR, the result is exactly the same as when i don't specify custom fees, which is expected because the values are the default ones
image

Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
ATOM sending works as expected for default and custom fee.
Fee reduced by 4-5 times.

@smk762 smk762 merged commit 76b10b6 into v7-dev Dec 13, 2023
6 checks passed
@smk762 smk762 mentioned this pull request Dec 20, 2023
@smk762 smk762 deleted the fix-tendermint-fee branch January 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants