Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out disabled coins in simple mode #2387

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Filter out disabled coins in simple mode #2387

merged 2 commits into from
Dec 13, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 10, 2023

Closes #2357

To test:

  • Go to simple mode, select a sell coin and price.
  • click to open the buy coin selection screen.
  • See disabled coins row faded
  • use checkbox to hide disabled coins

@smk762 smk762 requested review from cipig and kivqa December 10, 2023 17:13
cipig
cipig approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

disabled coins are greyed out
image

when i check "Show only enabled coins", the greyed out coins are gone
image

kivqa
kivqa approved these changes Dec 11, 2023
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Disabled coins are faded on Swap form. Show only enabled coins works as expected as well.
No regression for swap was found.

@smk762 smk762 merged commit 4ca0145 into v7-dev Dec 13, 2023
6 checks passed
@smk762 smk762 mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@kivqa kivqa kivqa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smk762 @cipig @kivqa