Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add min value filter to simple mode #2389

Merged
merged 3 commits into from
Dec 15, 2023
Merged

add min value filter to simple mode #2389

merged 3 commits into from
Dec 15, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 13, 2023 •
edited
Loading

minvol_filter.mp4

Last minute enhancement related to the disabled coins filter.

To test:

  • follow the video
  • confirm filter input removes orders less than value

Also pushed another feature to this branch unintentionlly. To test it:

  • check your rpc pass in settings > view seeds
  • toggle the Reuse static RPC password setting to on.
  • Log out, then back in.
  • Confirm rpc pass is same as it was.
  • toggle the Reuse static RPC password setting to off.
  • Log out, then back in.
  • Confirm rpc pass is different.

@smk762 smk762 requested review from cipig and kivqa December 13, 2023 20:07
cipig
cipig approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything works as expected

kivqa
kivqa approved these changes Dec 14, 2023
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Fiat filter works as expected.
Checked on MacOS client

@smk762 smk762 merged commit a010e9a into v7-dev Dec 15, 2023
6 checks passed
This was referenced Dec 20, 2023
Open
Merged
@smk762 smk762 deleted the fade-simple-disabled branch January 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@kivqa kivqa kivqa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smk762 @cipig @kivqa