Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build warnings #2391

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Fix build warnings #2391

merged 6 commits into from
Dec 18, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 15, 2023

Some housekeeping. To test, launch and do some basic smoke, activation, swap etc.
Changes are minor and there should be no regression.

  • removed some unused variables
  • fixed a search input to string literal
  • added missing return value for function is conditional fails.

@smk762 smk762 requested review from cipig and kivqa December 15, 2023 06:03
@smk762 smk762 merged commit a9f2718 into v7-dev Dec 18, 2023
6 checks passed
@smk762 smk762 mentioned this pull request Dec 20, 2023
Merged
@smk762 smk762 deleted the fix-build-warnings branch January 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@kivqa kivqa Awaiting requested review from kivqa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smk762 @cipig