Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pair trades 24hr stat #2415

Merged
merged 1 commit into from
Apr 1, 2024
Merged

add pair trades 24hr stat #2415

merged 1 commit into from
Apr 1, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 28, 2024

Before:
image

After:
image

To test:

  • Check a few random pairs in dex pro view.
  • If pair has stats data at https://defi-stats.komodo.earth/api/v3/pairs/volumes_24hr it should display below the orderbook.
  • If pair is not within the data from that endpoint, there have been no trades in the last 24 hours and there should be no stats shown under the orderbook.

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were successful. The following items were tested:

  • Comparing trades on DEX pro view with stats data from endpoint:
    • Number of trades matches
    • Trade Volume matches
    • No 24hr history underneath Order Book where no entry exists in stat data
  • UI around Order Book still functional and styled neatly

@smk762 smk762 merged commit 4a2d105 into dev Apr 1, 2024
6 checks passed
@smk762 smk762 deleted the update/defi-stats-api branch April 1, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants