Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabbed orderbook / bestorders #2416

Merged
merged 1 commit into from
Apr 2, 2024
Merged

tabbed orderbook / bestorders #2416

merged 1 commit into from
Apr 2, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 28, 2024

Before:

before.mp4

After:

after.mp4

To Test:

  • Login, go to dex pro view.
  • See tabbed orderbook / bestorders.
  • Click on things to confirm they respond as expected.

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing was successful. The following items were checked:

  • Functionality maintained
  • All UI elements can be accessed and data is visible
  • Tabbing between Order Book and Best Orders is functional
  • Selecting different exchange rates updates information and populates Best Orders
  • Selected exchange information persists when tabbing between Order Book / Best Orders
  • Tooltips appear on hover in Order Book

@smk762 smk762 merged commit 8dbad10 into dev Apr 2, 2024
6 checks passed
@TheComputerGenie
Copy link

TheComputerGenie commented Apr 13, 2024

Before:
before.mp4

After:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants