Fix some main loop crashes #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
what about https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/src/core/atomicdex/models/qt.portfolio.model.cpp#L157 ? can you enable that log line too? because i fear that this task takes a much too long time... you can also see this when you have 200 coins enabled and simply stay on portfolio page, the app will stall for couple seconds from time to time... and i suspect it does in this task |
Done |
|
Ok I got my first crash during the night: I just let the application idle and saw a double free this morning :/
|
Found where the double free happens:
|
ghost
marked this pull request as ready for review
|
Please test whenever you have time, the CI builds in debug mode so if you can run your testing session with gdb/lldb or any other debugger it will help me catch where are the problems Also Ubuntu CI seems broken I cannot make it build in debug, if someone can help me :) |
For
This one failed because Github has CI brownouts periodically to remind users to update before 18.04 is EOL. Give 20.04 a shot. |
|
there are several changes needed to make it compile under ubuntu 22.04... the above error comes from this package: https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/ci_tools_atomic_dex/ci_scripts/linux_script.sh#L28 but there is more... had to add btw, my builds are made with 20.04 since a long time, so i already use ADEX Desktop compiled for 20.04: https://github.com/cipig/atomicDEX-Desktop/blob/nogeo/.github/workflows/atomicdex-desktop-ci.yml#L32 |
|
oh, doesn't compile for ubuntu any more: |
It's weird, CMake wrote twice |
added 7 commits
October 24, 2022 12:31
|
i managed to make it crash... it was running in the background... this are the last entries in log file/console: btw, where does |
|
got a new one looks like this one is related to bad internet... |
cipig
previously approved these changes
Oct 31, 2022
smk762
previously approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Progress has been made, and it seems the remaining problems are likely related to pre-existing problems related to #2026
App is sufficiently stable for release and we can tackle the cpprestsdk issues in next iteration as it is too large a task to complete before 0.5.7
|
agree, i had no hard crash with this in the last time |
cipig
reviewed
Nov 1, 2022
cipig
approved these changes
Nov 1, 2022
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2002