Fix: FDISK not working on korean MSX computers #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konamiman
force-pushed
the
fix/fdisk-on-korean-machines
branch
6 times, most recently
from
de97f5d to
261c1d3
Compare
The problem (visible at least in the Daewoo CPC-400) is that the CHPUT routine is supposed to not modify the IX and IY registers, but in this computer it does since it does an inter-slot call to an internal slot (presumably to handle korean characters); this causes the PRINTF routine used by FDISK to crash. Additionally, a small hack is added to print one less "-" character in the upper and lower rulers when that inter-slot call is performed, otherwise the FDISK screen isn't printed properly (it introduces an additional line break for some reason).
Konamiman
force-pushed
the
fix/fdisk-on-korean-machines
branch
from
261c1d3 to
0740e07
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem (visible at least in the Daewoo CPC-400) is that the CHPUT routine is supposed to not modify the IX and IY registers, but in this computer it does since it does an inter-slot call to an internal slot (presumably to handle korean characters); this causes the PRINTF routine used by FDISK to crash.
Additionally, a small hack is added to print one less "-" character in the upper and lower rulers when that inter-slot call is performed, otherwise the FDISK screen isn't printed properly (it introduces an additional line break for some reason).
Closes #100