Skip to content

Commit

Permalink
fix(webhook) exclude Helm Secrets
Browse files Browse the repository at this point in the history
Helm charts with webhooks that handle Secrets run into an issue that
prevents changes after an action that enables the webhook:
helm/helm#10023

Because Helm's Secret for release information is subject to the webhook,
Kubernetes will attempt to validate it, likely before the webhook
service comes online (because Helm just created the Pod that will
provide it). If the service is not online, validation fails, and Helm
cannot update its Secret to mark the release status, usually leaving it
stuck in a pending state that blocks future interactions.

This change excludes Helm Secrets from our validation, because we have
no need to validate them.
  • Loading branch information
Travis Raines authored and rainest committed Nov 24, 2021
1 parent 91d93fa commit 4ebfe8d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions charts/kong/templates/admission-webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ metadata:
{{- include "kong.metaLabels" . | nindent 4 }}
webhooks:
- name: validations.kong.konghq.com
objectSelector:
matchLabels:
owner: !helm
failurePolicy: {{ .Values.ingressController.admissionWebhook.failurePolicy }}
sideEffects: None
admissionReviewVersions: ["v1beta1"]
Expand Down

0 comments on commit 4ebfe8d

Please sign in to comment.