Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: add gateway-discovery example and CI values #878

Merged
merged 1 commit into from
Aug 30, 2023
Merged

ingress: add gateway-discovery example and CI values #878

merged 1 commit into from
Aug 30, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Aug 28, 2023 •
edited
Loading

What this PR does / why we need it:

This PR adds gateway-discovery values.yaml file to exemplar values in ingress chart and also adds a similar (with disabled anonymous reporting) one to ci/ directory and enables ct install testing for ingress chart.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pmalek pmalek added documentation Improvements or additions to documentation area/ci labels Aug 28, 2023
@pmalek pmalek self-assigned this Aug 28, 2023
@pmalek pmalek marked this pull request as ready for review August 28, 2023 13:52
@pmalek pmalek requested a review from a team as a code owner August 28, 2023 13:52
@pmalek pmalek requested a review from mheap August 28, 2023 13:53
czeslavo
czeslavo approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@pmalek pmalek mentioned this pull request Aug 30, 2023
Open
1 task
@pmalek pmalek merged commit 84f257a into main Aug 30, 2023
18 checks passed
@pmalek pmalek deleted the ingress-add-gateway-discovery-example-and-ci-values branch August 30, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

@mheap mheap Awaiting requested review from mheap

Assignees

@pmalek pmalek

Labels
area/ci documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @czeslavo