GW Entity Targets #178
Merged
GW Entity Targets #178
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fabianrbz
reviewed
Dec 19, 2024
fabianrbz
reviewed
Dec 19, 2024
app/_gateway_entities/target.md
Outdated
| ## Set up a Target | ||
|
|
||
| {% entity_example %} | ||
| type: target |
There was a problem hiding this comment.
Suggested change
| type: target | |
| type: target | |
| data: | |
| target: httpbun.com:80 | |
| weight: 100 | |
This should be just one target
fabianrbz
reviewed
Dec 19, 2024
app/_gateway_entities/target.md
Outdated
| - target: httpbun.com:80 | ||
| weight: 100 | ||
| - target: httpbin.konghq.com:80 | ||
| weight: 100 |
There was a problem hiding this comment.
we need to add the instructions here
fabianrbz
reviewed
Dec 19, 2024
app/_gateway_entities/target.md
Outdated
Comment on lines
56
to
57
| style id1 rx:10,ry:10 | ||
| style id2 stroke:none |
There was a problem hiding this comment.
we can remove these lines
fabianrbz
reviewed
Dec 19, 2024
app/_gateway_entities/target.md
Outdated
|
|
||
| ## Use cases for targets | ||
| subgraph id2 ["`Targets (example_upstream)`"] |
There was a problem hiding this comment.
Suggested change
| subgraph id2 ["`Targets (example_upstream)`"] | |
| subgraph id2 ["`Targets`"] |
This is a known issue, I would say let's remove the extra text for now
fabianrbz
reviewed
Dec 19, 2024
app/_gateway_entities/target.md
Outdated
| ## What is a target? | ||
| ## What is a Target? | ||
|
|
||
| {{page.description}} Each [Upstream](/gateway/entities/upstream/) can have many Targets. Targets are used by Upstreams for load balancing. For example, if you have an `example_upstream` Upstream, you can point it to two different Targets: `httpbin.konghq.com` and `httpbun.com`. This is so that if one of the servers (like `httpbin.konghq.com`) is unavailable, it automatically detects the problem and routes all traffic to the working server (`httpbun.com`). |
There was a problem hiding this comment.
Can we write a full sentence instead of including the description? It might change in the future and I wouldn't expect it to affect the first paragraph
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
cloudjumpercat
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Links
Pulled from here
#168
Checklist