Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Saml Login support in Konnect #7481

Merged
merged 24 commits into from
Aug 7, 2024
Merged

Feat: Saml Login support in Konnect #7481

merged 24 commits into from
Aug 7, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Jun 6, 2024

https://konghq.atlassian.net/browse/DOCU-3737

Konnect now supports SAML authentication protocol for login. SAML is an open standard that allows Konnect to delegate authentication to an identity provider (IdP). By implementing SAML, organizations are able to choose between OIDC or SAML protocols when setting up their single sign on method.

https://deploy-preview-7481--kongdocs.netlify.app/konnect/org-management/sso/
https://deploy-preview-7481--kongdocs.netlify.app/konnect/org-management/okta-idp/

XR: #7370

@Guaris Guaris added review:copyedit Request for writer review. review:sme Request for SME review, external to the docs team. labels Jun 6, 2024
@Guaris Guaris requested a review from a team as a code owner June 6, 2024 16:31
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 36b8c32
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66b28be39ba91b0008ca7653
😎 Deploy Preview https://deploy-preview-7481--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 95 (🟢 up 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris marked this pull request as draft June 6, 2024 16:32
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, let me know if you have questions!

app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/saml-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/saml-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/saml-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/saml-idp.md Outdated Show resolved Hide resolved
app/konnect/updates.md Outdated Show resolved Hide resolved
@@ -0,0 +1,62 @@
---
title: Set up SSO with SAML 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need this doc to be separate if we already cover this flow in the Okta doc.

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
app/konnect/org-management/saml-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved

As an alternative to {{site.konnect_saas}}’s native authentication, you can set up single sign-on (SSO) access to {{site.konnect_short_name}} through an identity provider (IdP) using SAML 2.0. This method allows your users to log in to {{site.konnect_saas}} with their IdP credentials, eliminating the need for a separate login.

## Prerequisites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another prerequisite we have is that Konnect only allows for 1 idp at the time. If another idp is enabled, it will be required to disable it first. This will also be true for OIDC. 1 OIDC or 1 SAML.

app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
Guaris and others added 3 commits July 18, 2024 14:33
Co-authored-by: Alex Gervais <alex.gervais@gmail.com>
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step by step instructions look good, the tabs look good, but I am getting hung up on the existence of these two topics: Okta SSO and SSO. I think we need to do a couple of things to avoid confusion:

  • Link between the two topics, right at the top, in the intros. Say something like "this topics covers custom SSO for your IdPs. If you want to set up Okta SSO, see [link]" (not sure if that's correct, but something similar).
  • Adjust the title of the generic one to call out that it's generic
  • Add something to the overview to explain the difference

@@ -239,8 +239,8 @@
url: /org-management/social-identity-login/
- text: Org Switcher
url: /org-management/org-switcher/
- text: Set up SSO with OIDC
url: /org-management/oidc-idp/
- text: Set up SSO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this topic meant to be a more generic OSS config, vs the Okta one? It's really hard to tell the difference in purpose between the two topics at first glance, especially in the nav.

@Guaris Guaris marked this pull request as ready for review July 30, 2024 19:18
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Show resolved Hide resolved
Guaris and others added 2 commits July 31, 2024 10:57
Co-authored-by: Alex Gervais <alex.gervais@gmail.com>
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix tab nesting and heading, mainly. Otherwise, minimal feedback.

app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
Guaris and others added 4 commits August 1, 2024 11:53
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, but I think they could be fast follows if you need to release this asap, so I'm going to approve it now. Overall, I like the format and how you broke things up into a generic doc as well as a doc for Okta!

app/konnect/org-management/sso.md Outdated Show resolved Hide resolved
app/konnect/org-management/sso.md Show resolved Hide resolved

## Prepare the Okta application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the Okta-specific instructions in this doc, I think we're still too specific about the names of the buttons in the UI and precise steps. I'd keep it more general with links to Okta docs to make sure the steps are more likely to stay up-to-date. You can take a look at https://deploy-preview-7633--kongdocs.netlify.app/konnect/dev-portal/access-and-approval/sso/#configure-an-application-and-group-claims-in-your-idp for an example of what I'm thinking and how I did it for Dev Portal.

app/konnect/org-management/okta-idp.md Outdated Show resolved Hide resolved
Guaris and others added 2 commits August 2, 2024 13:34
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, but I have one question: the sections "Provider specific SAML configuration" and "Advanced OIDC settings" are both nested under "Troubleshooting". Is that an accident, or is there an argument for listing them as troubleshooting items instead of just references?

@smritikjaggi smritikjaggi merged commit ca3a9a2 into main Aug 7, 2024
15 checks passed
@smritikjaggi smritikjaggi deleted the DOCU-3737 branch August 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review. review:sme Request for SME review, external to the docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants