Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding migration guide for on-prem to konnect #7482

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

rspurgeon
Copy link
Contributor

@rspurgeon rspurgeon commented Jun 6, 2024

@rspurgeon rspurgeon added the do not merge Issues/ PRs whose changes should not be merged at this time label Jun 6, 2024
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 314b5de
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66a01fb694414c0008e92330
😎 Deploy Preview https://deploy-preview-7482--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 94 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jul 4, 2024
@rspurgeon rspurgeon force-pushed the ee-to-konnect-guide branch 2 times, most recently from 026ea45 to f2ecea7 Compare July 17, 2024 00:29
@rspurgeon rspurgeon marked this pull request as ready for review July 17, 2024 14:44
@rspurgeon rspurgeon requested a review from a team as a code owner July 17, 2024 14:44
@rspurgeon rspurgeon changed the title WIP: Adding migration guide for on-prem to konnect Adding migration guide for on-prem to konnect Jul 17, 2024
@rspurgeon rspurgeon removed the do not merge Issues/ PRs whose changes should not be merged at this time label Jul 17, 2024
@lena-larionova
Copy link
Contributor

Mid-reviewing right now, but one thought: should we combine your guide with this topic? https://deploy-preview-7482--kongdocs.netlify.app/konnect/getting-started/import/ - or does it still serve a standalone purpose in a "Getting started" context 🤔 ?

I also don't think this page quite belongs in the "Introduction", but there's no existing section for it either. It might be better to have it stand alone, as a top-level item.

@rspurgeon
Copy link
Contributor Author

Mid-reviewing right now, but one thought: should we combine your guide with this topic? https://deploy-preview-7482--kongdocs.netlify.app/konnect/getting-started/import/ - or does it still serve a standalone purpose in a "Getting started" context 🤔 ?

I also don't think this page quite belongs in the "Introduction", but there's no existing section for it either. It might be better to have it stand alone, as a top-level item.

Thanks @lena-larionova. I agree these pages overlap. I would vote to have the new page supersede the current "Import" page. I don't think the current page covers anything that the new page does not except for the CTAs at the bottom. I could copy those over if you agree.

We could also move the new page into the Getting Started section where the current page is if that makes more sense.

@rspurgeon
Copy link
Contributor Author

@lena-larionova I refactored this based on my previous comment and rebased of main. Let me know what you think. Thanks for the review.

Copy link
Contributor

@Guaris Guaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this doc is trying to solve two things at once. It feels like it is trying to teach me the concepts of migration and showing me how to do some pieces of the migration process. The headings bury a lot of key information under the large umbrella of Migration Guide.

What if you structured the information sort of like this:

## The migration process

A high level overview of the steps, maybe a chart that shows what order we recommend migrating things in. 

### Pre-migration

Things like making sure you have the right roles and permissions configured. 
A Konnect Account with the right permissions
Maybe even the section on stripping metadata from your workspaces. 
IAM section? 


## Migrating the Kong Gateway Configuration

The general process for migrating the configuration involves “dumping” your existing on-premises configuration to a local file, modifying the configuration slightly to remove any workspace specific metadata, and then synchronizing the configuration to your desired Control Plane in Kong Konnect.

### Export from Kong Gateway
- Using decK to Export Configuration

### Modify the configuration
- Metadata
- other things that you might want to modify here

### Import to Konnect


## Plugins

## Additional migration information
## Other Konnect use cases

Hopefully that makes sense, In essence, I think having a lot of information for a topic like this can be very good, but I think the steps that lead a user to the outcome of migration should be prioritized.

Comment on lines +215 to +219
```sh
yq -i 'del(._workspace)' default.yaml
yq -i 'del(._workspace)' inventory.yaml
yq -i 'del(._workspace)' sales.yaml
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use something built-in like sed or awk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this isn't necessary. yq and jq are standard in developer workflows that manipulate files of these formats. Given this is a "hint" to how to perform the migration and not a recipe for any automated workflow, I don't think the use of the tool is concerning.

@@ -0,0 +1,318 @@
---
title: Migrating from Kong Gateway On-Premises to Kong Konnect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the title I'm expecting a step-by-step guide on how to migrate. The steps written feel more abstract, and I understand that everyones case is different but if we want to use illustrative steps maybe we can reorder them so that they express a recommended order of operations?

Like:

  1. Export config
  2. Modify Config
  3. Import config
  4. Setup RBAC
  5. Migrate Data planes
    Then you have extra information that may not apply to everyone like:
    Handling plugins

app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
app/konnect/getting-started/migration.md Outdated Show resolved Hide resolved
@lena-larionova lena-larionova merged commit 36c543f into main Jul 23, 2024
15 checks passed
@lena-larionova lena-larionova deleted the ee-to-konnect-guide branch July 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants