Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(kic): update about gRPC routing #7501

Merged
merged 11 commits into from
Jun 12, 2024
Merged

docs(kic): update about gRPC routing #7501

merged 11 commits into from
Jun 12, 2024

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Jun 11, 2024 •
edited
Loading

@tao12345666333
kic: update about gRPC routing
e577c9a 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 added review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? area/gateway-api labels Jun 11, 2024
@tao12345666333 tao12345666333 requested a review from a team as a code owner June 11, 2024 15:45
@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 89a36ac
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6669da3b9842d9000898e376
😎 Deploy Preview https://deploy-preview-7501--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 95 (🟢 up 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tao12345666333 tao12345666333 added the Kubernetes Team Kubernetes task tracking (including KIC) label Jun 11, 2024
@tao12345666333 tao12345666333 changed the title kic: update about gRPC routing docs(kic): update about gRPC routing Jun 11, 2024
tao12345666333 and others added 3 commits June 12, 2024 00:05
@tao12345666333
correct indentation.
8b14b28 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Merge branch 'main' into kic-grpcroute-update
b1fe4a5
@cloudjumpercat
Add conditional rendering
e9750b3 
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
cloudjumpercat
cloudjumpercat reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple wording suggestions and also added conditional rendering since this change is for 3.2 and won't apply to earlier versions, correct?

app/_src/kubernetes-ingress-controller/guides/services/grpc.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/guides/services/grpc.md Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member Author

Yes, thank you!

tao12345666333 and others added 3 commits June 12, 2024 12:25
@tao12345666333 @cloudjumpercat
Apply suggestions from code review
e325ebe 
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@tao12345666333
fix typo
10b8c62 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Merge branch 'main' into kic-grpcroute-update
1734886
@czeslavo czeslavo added this to the KIC v3.2 milestone Jun 12, 2024
@cloudjumpercat
Fix conditional rendering for over HTTP instructions
906a65b 
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@cloudjumpercat
Appease Vale
89a36ac 
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
cloudjumpercat
cloudjumpercat approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cloudjumpercat cloudjumpercat merged commit a6d8b56 into main Jun 12, 2024
15 checks passed
@cloudjumpercat cloudjumpercat deleted the kic-grpcroute-update branch June 12, 2024 17:40
@tao12345666333 tao12345666333 mentioned this pull request Jun 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

Assignees
No one assigned
Labels
area/gateway-api Kubernetes Team Kubernetes task tracking (including KIC) review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
KIC v3.2
Development

Successfully merging this pull request may close these issues.

GRPCRoute conformance
3 participants
@tao12345666333 @cloudjumpercat @czeslavo