-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Konnect Advanced Analytics #7546
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Co-authored-by: Christian Heidenreich <sichvoge@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the benefits, I would stay close to what we have here (see the Benefits section). I am ok to rephrase it a bit but specifically the last one in the PR is more the "feature" not a benefit. 🙂 Otherwise, this is looking great to me. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about how to describe the distinction between advanced and basic.
Co-authored-by: Rocky <adorack@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few questions/comments and some suggestions! Let me know if you have any questions or if you'd like another review!
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Rocky <adorack@users.noreply.github.com>
app/assets/images/products/konnect/changelog/konnect-control-plane-without-analytics.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Christian Heidenreich <sichvoge@users.noreply.github.com>
Co-authored-by: Christian Heidenreich <sichvoge@users.noreply.github.com>
Pages:
https://deploy-preview-7546--kongdocs.netlify.app/konnect/analytics/
https://deploy-preview-7546--kongdocs.netlify.app/konnect/analytics/api-requests/
Removed the troubleshooting section.
https://konghq.atlassian.net/browse/DOCU-3760
https://konghq.atlassian.net/browse/DOCU-3617
https://konghq.atlassian.net/browse/DOCU-3763