Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Konnect Advanced Analytics #7546

Merged
merged 25 commits into from
Aug 1, 2024
Merged

Feat: Konnect Advanced Analytics #7546

merged 25 commits into from
Aug 1, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Jun 18, 2024 •
edited

@Guaris Guaris added do not merge Issues/ PRs whose changes should not be merged at this time review:sme Request for SME review, external to the docs team. labels Jun 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 411c602
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66abae768668b1000801bb13
😎 Deploy Preview https://deploy-preview-7546--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 93 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Guaris and others added 3 commits June 18, 2024 14:30
@Guaris
basic -> advanced
213ed12
@cloudjumpercat @Guaris
Add changelog and changelog picture
499ba98 
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@cloudjumpercat @Guaris
Revise some of the wording
d46ba7a 
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@Guaris Guaris mentioned this pull request Jun 18, 2024
Closed
2 tasks
sichvoge
sichvoge requested changes Jun 26, 2024
View reviewed changes
app/konnect/updates.md Outdated Show resolved Hide resolved
app/konnect/updates.md Outdated Show resolved Hide resolved
Guaris
Guaris commented Jun 26, 2024
View reviewed changes
app/konnect/updates.md Outdated Show resolved Hide resolved
@Guaris Guaris requested a review from sichvoge June 27, 2024 15:59
@Guaris Guaris marked this pull request as ready for review June 27, 2024 16:01
@Guaris Guaris requested a review from a team as a code owner June 27, 2024 16:01
sichvoge
sichvoge requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@sichvoge sichvoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the benefits, I would stay close to what we have here (see the Benefits section). I am ok to rephrase it a bit but specifically the last one in the PR is more the "feature" not a benefit. 🙂 Otherwise, this is looking great to me. Well done!

app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
adorack
adorack reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about how to describe the distinction between advanced and basic.

app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
Guaris and others added 3 commits June 28, 2024 09:27
@Guaris @adorack
Apply suggestions from code review
862b1a5 
Co-authored-by: Rocky <adorack@users.noreply.github.com>
@Guaris
remove badge
b63b689
@Guaris
ingestion + benefits
885d57c
cloudjumpercat
cloudjumpercat reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions/comments and some suggestions! Let me know if you have any questions or if you'd like another review!

app/konnect/analytics/troubleshoot.md Outdated Show resolved Hide resolved
app/konnect/updates.md Outdated Show resolved Hide resolved
app/konnect/analytics/api-requests.md Show resolved Hide resolved
app/_data/docs_nav_konnect.yml Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
app/konnect/updates.md Outdated Show resolved Hide resolved
app/konnect/updates.md Show resolved Hide resolved
Guaris and others added 2 commits June 28, 2024 13:24
@Guaris @cloudjumpercat
Apply suggestions from code review
6a664ca 
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@Guaris
Suggestions and edits
61ab32c
cloudjumpercat
cloudjumpercat approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Guaris Guaris requested a review from sichvoge June 28, 2024 19:03
@Guaris @adorack
Update app/konnect/analytics/index.md
88e92f0 
Co-authored-by: Rocky <adorack@users.noreply.github.com>
@Guaris Guaris removed the do not merge Issues/ PRs whose changes should not be merged at this time label Jul 1, 2024
@Guaris Guaris changed the title Feat: Analytics new SKU Feat: Konnect Advanced Analytics Jul 1, 2024
@Guaris Guaris added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jul 1, 2024
@Guaris Guaris mentioned this pull request Jul 22, 2024
Closed
sichvoge
sichvoge previously requested changes Jul 31, 2024
View reviewed changes
app/konnect/updates.md Outdated Show resolved Hide resolved
@Guaris @sichvoge
Update app/konnect/updates.md
07afb53 
Co-authored-by: Christian Heidenreich <sichvoge@users.noreply.github.com>
sichvoge
sichvoge requested changes Aug 1, 2024
View reviewed changes
app/konnect/analytics/index.md Outdated Show resolved Hide resolved
@Guaris @sichvoge
Update app/konnect/analytics/index.md
411c602 
Co-authored-by: Christian Heidenreich <sichvoge@users.noreply.github.com>
@sichvoge sichvoge merged commit b7453aa into main Aug 1, 2024
14 of 15 checks passed
@sichvoge sichvoge deleted the DOCU3617 branch August 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorack adorack adorack left review comments

@ryanmoore ryanmoore ryanmoore left review comments

@sichvoge sichvoge sichvoge approved these changes

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:sme Request for SME review, external to the docs team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Guaris @adorack @sichvoge @ryanmoore @cloudjumpercat