Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mesh): add prod usage helm values #7640

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Conversation

jijiechen
Copy link
Member

@jijiechen jijiechen commented Jul 15, 2024

Description

fixes #7507

replaces #7508

Testing instructions

Preview link:

2.8.x
dev - 2.9

Checklist

Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
@jijiechen jijiechen added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jul 15, 2024
@jijiechen jijiechen requested a review from a team as a code owner July 15, 2024 03:08
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit ea56a5b
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/669f1245eb96f200085d9997
😎 Deploy Preview https://deploy-preview-7640--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jijiechen jijiechen changed the title Kong mesh prod values docs(mesh): add prod usage helm values Jul 15, 2024
@jijiechen
Copy link
Member Author

The content accuracy was discussed and approved in this doc of the mesh repo:
https://github.com/Kong/kong-mesh/pull/5892

@jijiechen
Copy link
Member Author

This PR replaces the previous one at #7508
All suggestions as of July 15 are fixed.

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit on the headers, as they don't function properly inside navtab elements. Just need to switch them to regular text. Otherwise, LGTM

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@jijiechen jijiechen merged commit 8df5693 into main Jul 23, 2024
15 checks passed
@jijiechen jijiechen deleted the kong-mesh-prod-values branch July 23, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a documentation to suggested values.yaml for Kong Mesh production installations
4 participants