-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more explanation for hashicorp vault's authentication and secret fetching #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lena-larionova
requested changes
Jul 22, 2024
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Show resolved
Hide resolved
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@lena-larionova Thank you very much for the detailed review! The preview page looks good |
app/_src/gateway/kong-enterprise/secrets-management/backends/hashicorp-vault.md
Outdated
Show resolved
Hide resolved
…ashicorp-vault.md Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
lena-larionova
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great addition to the doc :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
review:tech
Request for technical review on the docs platform or processes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a section to the Kong Gateway's HashiCorp Vault backend, describing how Kong does authentication and retrieving secrets by calling HashiCorp Vault's API. This could help users to set a correct
mount
,namespace
,auth_path
and secret reference path.https://konghq.atlassian.net/browse/FTI-6071
Testing instructions
Preview link:
Checklist