Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more explanation for hashicorp vault's authentication and secret fetching #7650

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Jul 17, 2024

Description

This PR adds a section to the Kong Gateway's HashiCorp Vault backend, describing how Kong does authentication and retrieving secrets by calling HashiCorp Vault's API. This could help users to set a correct mount, namespace, auth_path and secret reference path.

https://konghq.atlassian.net/browse/FTI-6071

Testing instructions

Preview link:

Checklist

@windmgc windmgc added review:tech Request for technical review on the docs platform or processes. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Jul 17, 2024
@windmgc windmgc requested a review from a team as a code owner July 17, 2024 07:40
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 97121dd
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/669fcb98bad57f0008c42167
😎 Deploy Preview https://deploy-preview-7650--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 94 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
@windmgc
Copy link
Member Author

windmgc commented Jul 23, 2024

@lena-larionova Thank you very much for the detailed review! The preview page looks good

…ashicorp-vault.md

Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great addition to the doc :)

@lena-larionova lena-larionova merged commit 91d2a99 into main Jul 24, 2024
15 checks passed
@lena-larionova lena-larionova deleted the hcv-vault-path-description branch July 24, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants