Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add documentation about assume role support for rds iam authentication #7651

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Jul 17, 2024

Description

This is a new feature developed in 3.8.
The PR adds the corresponding descriptions about how to enable the new feature that does role assuming when doing RDS IAM authentication.

https://konghq.atlassian.net/browse/KAG-4561

Testing instructions

Preview link:

Checklist

@windmgc windmgc added review:tech Request for technical review on the docs platform or processes. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Jul 17, 2024
@windmgc windmgc requested a review from a team as a code owner July 17, 2024 08:33
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 3003941
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/669f1d553801e30008ac0bd8
😎 Deploy Preview https://deploy-preview-7651--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 94 (🟢 up 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat cloudjumpercat added this to the Gateway 3.8 milestone Jul 17, 2024
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All minor edits.

@lena-larionova lena-larionova self-assigned this Jul 22, 2024
Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't tell if your eng-side PR has been merged, so feel free to merge this doc whenever that goes in.

@windmgc
Copy link
Member Author

windmgc commented Jul 25, 2024

Yes it has been merged here: https://github.com/Kong/kong-ee/pull/8721

Thanks for your review! @lena-larionova

@windmgc windmgc merged commit 727d205 into main Jul 25, 2024
15 checks passed
@windmgc windmgc deleted the feat-rds-iam-assume-role branch July 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants