Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace httpbin.org with httpbin.konghq.com #7991

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

lmilan
Copy link
Contributor

@lmilan lmilan commented Oct 2, 2024

Description

DOCU-4088

Checklist

  • Review label added

@lmilan lmilan added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 2, 2024
@lmilan lmilan self-assigned this Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit a33beb7
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66fdcd65c08c5e00088f95cd
😎 Deploy Preview https://deploy-preview-7991--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93
Accessibility: 92
Best Practices: 98
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lmilan lmilan marked this pull request as ready for review October 2, 2024 08:24
@lmilan lmilan requested a review from a team as a code owner October 2, 2024 08:24
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I added a manual link checker approval label to the PR as the failures were all 429s from Github, so they're false positives - github sometimes rate limits us if we try to ping them via the link checker too quickly 😅

Also resolved a conflict with one of the other merged bug bash PRs. We're good to go.

@lena-larionova lena-larionova merged commit a6425db into main Oct 2, 2024
15 checks passed
@lena-larionova lena-larionova deleted the DOCU-4088 branch October 2, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:check-skipped:generated-files ci:manual-approve:link-validation review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants