Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Config file structure #7994

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

lmilan
Copy link
Contributor

@lmilan lmilan commented Oct 2, 2024

Description

issue reported through docs feecback

Testing instructions

Preview link:

@lmilan lmilan added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 2, 2024
@lmilan lmilan self-assigned this Oct 2, 2024
@lmilan lmilan requested a review from a team as a code owner October 2, 2024 13:03
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit b4f86bd
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66fd71a1fa05940008f23350
😎 Deploy Preview https://deploy-preview-7994--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 124 to 126
- name: admin-api
paths:
- /admin-api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the indents are a bit off, the - name should align with the start of routes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@lena-larionova lena-larionova merged commit 1d8a7a1 into main Oct 2, 2024
15 checks passed
@lena-larionova lena-larionova deleted the fix-secure-admin-api-config branch October 2, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants