Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(*): add more tips while using multiple domains #8059

Merged
merged 4 commits into from
Oct 28, 2024
Merged

docs(*): add more tips while using multiple domains #8059

merged 4 commits into from
Oct 28, 2024

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Oct 17, 2024 •
edited
Loading

Description

Testing instructions

Preview link:
https://deploy-preview-8059--kongdocs.netlify.app/
image

Checklist

KM-599

@raoxiaoyan raoxiaoyan requested a review from a team as a code owner October 17, 2024 06:32
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 9624238
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/671fd028a1f35000096cf4b7
😎 Deploy Preview https://deploy-preview-8059--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@raoxiaoyan raoxiaoyan marked this pull request as draft October 17, 2024 06:40
@raoxiaoyan raoxiaoyan added the review:copyedit Request for writer review. label Oct 17, 2024
@raoxiaoyan raoxiaoyan force-pushed the docs/KM-122-1 branch 3 times, most recently from e96d708 to 18787f8 Compare October 17, 2024 08:20
@raoxiaoyan raoxiaoyan self-assigned this Oct 17, 2024
@raoxiaoyan raoxiaoyan added this to the Gateway 3.9 milestone Oct 17, 2024
@raoxiaoyan raoxiaoyan marked this pull request as ready for review October 17, 2024 08:49
sumimakito
sumimakito reviewed Oct 17, 2024
View reviewed changes
app/_src/gateway/kong-manager/enable.md Outdated Show resolved Hide resolved
app/_src/gateway/kong-manager/enable.md Outdated Show resolved Hide resolved
app/_src/gateway/kong-manager/enable.md Outdated Show resolved Hide resolved
app/_src/gateway/kong-manager/enable.md Outdated Show resolved Hide resolved
@raoxiaoyan
Copy link
Contributor Author

@Guaris Could you help to merge it, please?

@Guaris Guaris merged commit 8011300 into main Oct 28, 2024
15 checks passed
@Guaris Guaris deleted the docs/KM-122-1 branch October 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

@Guaris Guaris Guaris approved these changes

Assignees

@raoxiaoyan raoxiaoyan

Labels
review:copyedit Request for writer review.
Projects
None yet
Milestone
Gateway 3.9
Development

Successfully merging this pull request may close these issues.
3 participants
@raoxiaoyan @sumimakito @Guaris