Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use mise to manage tools dependencies #17

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Mar 15, 2024

What this PR does / why we need it:

Replaces the current third_party dir based tools management with one based on mise.

The idea behind this change is to

  • do not compile tools locally but download binaries for them
  • remove third_party/go.mod and third_party/go.sum files

NOTE: the introduces .tools_versions.yaml will get renovate annotations so that we'll be able to get automatic PRs bumping tools version. One thing at a time though.

@pmalek pmalek self-assigned this Mar 15, 2024
@pmalek pmalek requested a review from a team as a code owner March 15, 2024 16:40
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and I like it 🎉

It will be worth mentioning in README that mise is a required tool for working with this repo

@pmalek
Copy link
Member Author

pmalek commented Mar 18, 2024

It works and I like it 🎉

It will be worth mentioning in README that mise is a required tool for working with this repo

I've added a link to the output when failing to find mise on the system. When README.md stabilizes on this repo and we end up adding TESTING.md we can add that there.

Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100 −4,798

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants