fix: fix ControlPlane managed resource labels during migration from 1.2 and older #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
changed the title
2 tasks
pmalek
force-pushed
the
fix-controlplane-managed-resources-labels-migration
branch
2 times, most recently
from
b0dd45f
to
ec1a893
Compare
pmalek
commented
Jul 5, 2024
pmalek
force-pushed
the
fix-controlplane-managed-resources-labels-migration
branch
from
ec1a893
to
f9dd643
Compare
pmalek
force-pushed
the
fix-controlplane-managed-resources-labels-migration
branch
5 times, most recently
from
a6650b1
to
007d337
Compare
programmer04
reviewed
Jul 7, 2024
controller/controlplane/controlplane_controller_reconciler_utils_test.go
Outdated
Show resolved
Hide resolved
programmer04
approved these changes
Jul 8, 2024
pmalek
changed the title
mlavacca
reviewed
Jul 9, 2024
mlavacca
approved these changes
Jul 9, 2024
pmalek
force-pushed
the
fix-controlplane-managed-resources-labels-migration
branch
from
a1d5f7b
to
18aa0d2
Compare
…lder operator versions
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
pmalek
force-pushed
the
fix-controlplane-managed-resources-labels-migration
branch
from
18aa0d2
to
a91bffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#259 introduced a new set of labels that are used on
ControlPlane'sClusterRolesClusterRoleBindingssValidatingWebhookConfigurationsThis omitted 1 important detail which is migrating on operator upgrade (specifically from 1.2.x and older to 1.3.0).
This PR fixes this by changing the listing and deleting logic for the aforementioned resources so that the old label and owner reference are also taken into account.
This also makes other small changes
ClusterRoleorValidatingWebhookConfigurationin place when there's more in the cluster;ControlPlanefails to get provisioned - this can happen when operator's webhook doesn't respond - requeue, without this, provisionedGatewaygets stuck withControlPlaneReadycondition set toFalse.Which issue this PR fixes
Fixes #373
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes