Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: gateway API bumped to v1.2.0-rc2 #674

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Oct 1, 2024

What this PR does / why we need it:

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

Conformance tests have been run locally and they are successful.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@mlavacca mlavacca requested a review from a team as a code owner October 1, 2024 08:33
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@pmalek
Copy link
Member

pmalek commented Oct 1, 2024

Is 1.2.0 aimed to be released before our release target date for 1.4.0? Otherwise we'd end up with using RC in 1.4.0 which I'd say is something we don't want to do.

Given that we might not be sure about the release date of 1.2.0 I suggest to keep this one as is until that happens so that we don't need to revert or rely on RC in a released version of KGO. WDYT?

@mlavacca
Copy link
Member Author

mlavacca commented Oct 1, 2024

Is 1.2.0 aimed to be released before our release target date for 1.4.0? Otherwise we'd end up with using RC in 1.4.0 which I'd say is something we don't want to do.

Given that we might not be sure about the release date of 1.2.0 I suggest to keep this one as is until that happens so that we don't need to revert or rely on RC in a released version of KGO. WDYT?

Yep, sounds good to me. I've asked the Gateway API folks about the candidate date for the actual 1.2 release, as I've been out for a while. Let's keep this PR as is and bump it once 1.2 is out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants