Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(konnect): refactor generating object tags #675

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore(konnect): refactor generating object tags #675

merged 1 commit into from
Oct 1, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 1, 2024

What this PR does / why we need it:

Extracts a common GenerateTagsForObject function to deduplicate code across get*Input functions.

Which issue this PR fixes

#663 followup.

@czeslavo czeslavo self-assigned this Oct 1, 2024
@czeslavo czeslavo added this to the KGO v1.4.x milestone Oct 1, 2024
@czeslavo czeslavo marked this pull request as ready for review October 1, 2024 09:51
@czeslavo czeslavo requested a review from a team as a code owner October 1, 2024 09:51
@czeslavo czeslavo mentioned this pull request Oct 1, 2024
Merged
1 task
pmalek
pmalek approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this improvement 🥇

@pmalek pmalek merged commit a554fdf into main Oct 1, 2024
21 checks passed
@pmalek pmalek deleted the chore/tags branch October 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees

@czeslavo czeslavo

Labels
area/konnect
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@czeslavo @pmalek