Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added integration test on HTTPS #88

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

mlavacca
Copy link
Member

What this PR does / why we need it:

a new Integration test on HTTPRoute with HTTPS traffic has been added

Which issue this PR fixes

Fixes #87

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [] the CHANGELOG.md release notes have been updated to reflect significant changes

@mlavacca mlavacca requested a review from a team as a code owner April 16, 2024 15:09
@mlavacca mlavacca force-pushed the mlavacca/HTTPS-integration-test branch from 1871546 to 4c2319e Compare April 16, 2024 15:09
test/integration/test_httproute.go Outdated Show resolved Hide resolved
test/integration/test_httproute.go Outdated Show resolved Hide resolved
test/integration/test_httproute.go Outdated Show resolved Hide resolved
@mlavacca mlavacca force-pushed the mlavacca/HTTPS-integration-test branch 4 times, most recently from f332864 to cbdd513 Compare April 18, 2024 16:10
@mlavacca
Copy link
Member Author

@czeslavo I factorized a lot of code between the two HTTPRoute tests, PTAL

@mlavacca mlavacca requested a review from czeslavo April 18, 2024 16:11
test/integration/run_integration_test.go Outdated Show resolved Hide resolved
test/integration/test_httproute.go Outdated Show resolved Hide resolved
@mlavacca mlavacca requested a review from czeslavo April 19, 2024 09:19
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

test/helpers/generators.go Show resolved Hide resolved
test/integration/suite.go Outdated Show resolved Hide resolved
test/helpers/http.go Outdated Show resolved Hide resolved
test/helpers/generators.go Outdated Show resolved Hide resolved
mlavacca and others added 3 commits April 22, 2024 11:35
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the mlavacca/HTTPS-integration-test branch from f30bebd to 17ed875 Compare April 22, 2024 09:35
@mlavacca mlavacca requested a review from pmalek April 22, 2024 09:35
@pmalek
Copy link
Member

pmalek commented Apr 22, 2024

Tests are failing

=== FAIL: test/integration TestIntegration/TestGatewayEssentials (29.31s)
    test_gateway.go:36: performing test setup
    test_gateway.go:36: creating a testing namespace
    test_gateway.go:36: using test namespace: cf23a136-587d-4eb9-89be-9ce685693de6
    test_gateway.go:38: deploying a GatewayClass resource
    test_gateway.go:41: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_gateway.go:41
        	Error:      	Received unexpected error:
        	            	GatewayClass.gateway.networking.k8s.io "8bc82141-0e42-4437-8458-9c65ccaf964a" is invalid: [spec.parametersRef.kind: Invalid value: "": spec.parametersRef.kind in body should be at least 1 chars long, spec.parametersRef.name: Invalid value: "": spec.parametersRef.name in body should be at least 1 chars long]
        	Test:       	TestIntegration/TestGatewayEssentials
W0422 09:41:35.403238   15594 warnings.go:70] unknown field "spec.controlPlaneOptions.deployment.podTemplateSpec.metadata.creationTimestamp"

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the mlavacca/HTTPS-integration-test branch from 17ed875 to 0789bef Compare April 22, 2024 09:55
@mlavacca
Copy link
Member Author

Tests are failing

=== FAIL: test/integration TestIntegration/TestGatewayEssentials (29.31s)
    test_gateway.go:36: performing test setup
    test_gateway.go:36: creating a testing namespace
    test_gateway.go:36: using test namespace: cf23a136-587d-4eb9-89be-9ce685693de6
    test_gateway.go:38: deploying a GatewayClass resource
    test_gateway.go:41: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_gateway.go:41
        	Error:      	Received unexpected error:
        	            	GatewayClass.gateway.networking.k8s.io "8bc82141-0e42-4437-8458-9c65ccaf964a" is invalid: [spec.parametersRef.kind: Invalid value: "": spec.parametersRef.kind in body should be at least 1 chars long, spec.parametersRef.name: Invalid value: "": spec.parametersRef.name in body should be at least 1 chars long]
        	Test:       	TestIntegration/TestGatewayEssentials
W0422 09:41:35.403238   15594 warnings.go:70] unknown field "spec.controlPlaneOptions.deployment.podTemplateSpec.metadata.creationTimestamp"

It's fixed now

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits which I do not consider blockers for this PR. 👍

test/integration/utils.go Show resolved Hide resolved
test/helpers/http.go Show resolved Hide resolved
test/helpers/generators.go Show resolved Hide resolved
@mlavacca mlavacca enabled auto-merge (squash) April 22, 2024 12:35
@mlavacca mlavacca merged commit 1929b68 into main Apr 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test for Gateway with HTTPS listeners
3 participants