Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Controller-Gen Compatibility #54

Closed
shaneutt opened this issue Apr 27, 2021 · 2 comments
Closed

Feature Request: Controller-Gen Compatibility #54

shaneutt opened this issue Apr 27, 2021 · 2 comments
Labels
wontfix This will not be worked on

Comments

@shaneutt
Copy link
Contributor

Currently in the Kong Kubernetes Ingress Controller (KIC) we use controller-gen as a generator for manifests and libraries within the project.

Currently types within this repository are not explicitly compatible due to Floats, and so the following flag has to be used:

allowDangerousTypes=true

The purpose of this issue is to ledger a request that we modify the types in a future go-kong release such that we would start intentionally maintaining explicit Kubernetes compatibility.

@mflendrich
Copy link
Contributor

such that we would start intentionally maintaining explicit Kubernetes compatibility

go-kong is a wrapper for Kong's API and the ultimate requirement is that types maintain explicit Kong compatibility.
If there are multiple types satisfying the Kong compatibility requirement, we can add a style guideline to prefer types that are convenient with Kubernetes. But I think that it's Kong that matters here most, not Kubernetes.

@mflendrich
Copy link
Contributor

won't fix - this is a direct consequence of the type on Admin API

As @rainest pointed out, this is "dangerous" because roundtripping isn't reliable for floats.

@mflendrich mflendrich added the wontfix This will not be worked on label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants