Use only int64 and float64

[mmorel-35]

Fixes #54

[mmorel-35]

I have used float on createdAt and updatedAt because of this : https://github.com/Kong/go-kong/runs/2574465387?check_suite_focus=true#step:7:279

[mflendrich]

Looks good, please however:

• see the comment Feature Request: Controller-Gen Compatibility #54 (comment) - it doesn't affect the code of this PR, just FYI
• see the action required (in the attached comment)
• be advised that I'm checking with maintainers of Kong Gateway that the created_at change from int to float is appropriate.

[mflendrich]

lll has 120 as the default and this is what we have configured in other repos. Why do you want to change that?

Suggestion: remove the customization (leave the default) and wrap all changed lines that require it.

[mmorel-35]

@mflendrich, this line is the reason why I changed lll parameters.
I can't find a way to resize it beneath 121 characters with int it's fine but with int64, it isn't

[rainest]

golangci supports per-file exemptions, which would be appropriate here. go-kong doesn't currently have any, but deck does: https://github.com/Kong/kong/blob/master/kong.conf.default#L98-L126 is an example for this rule.

[mmorel-35]

Are you sure of your link ?

[rainest]

Nope. Clipboard hurray. https://github.com/Kong/deck/blob/6fd816b2bb4603dc2479beeff8b6e1e7a6e1e167/.golangci.yml#L37-L40 was what I meant.

[rainest]

I don't think this fixes the issue. kubernetes-sigs/controller-tools#245 and the controller-gen source indicates that float64 isn't any permissible than float. The restriction exists because float conversions are inconsistent in and out of strings in JSON, not because of a need to support large or higher-precision values.

We'd approached this before in #17, which moves to a string-backed type, but decided against it because it's a breaking change in go-kong and allowDangerousTypes is available for KIC. The dangerous conversion should be minimal impact, since the problem fields are things we ignore in practice (created/updated at timestamps) or values where precision weirdness is probably low impact (health thresholds).

[mmorel-35]

OK, shall we drop the PR so ?

[rainest]

Yeah--wouldn't help the issue with controller-gen and we don't have other reasons to modify the types.

FWIW, the odd-looking discrepancy in the timestamp types is intentional. Kong actually defines both integer and float timestamp types, though only targets use the float variant.