Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-test secret check #246

Closed
wants to merge 1 commit into from
Closed

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Dec 8, 2022

Companion to #247.

This is a duplicate that demonstrates how this runs when the source is a fork.

@rainest rainest requested a review from a team as a code owner December 8, 2022 20:09
@rainest rainest closed this Dec 8, 2022
@pmalek pmalek reopened this Dec 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 53.31% // Head: 40.06% // Decreases project coverage by -13.24% ⚠️

Coverage data is based on head (83d3f9a) compared to base (3a619dd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #246       +/-   ##
===========================================
- Coverage   53.31%   40.06%   -13.25%     
===========================================
  Files          46       46               
  Lines        4183     4183               
===========================================
- Hits         2230     1676      -554     
- Misses       1478     2204      +726     
+ Partials      475      303      -172     
Flag Coverage Δ
2.1.4 40.06% <ø> (ø)
2.2.1.3 ?
2.2.2 40.06% <ø> (ø)
2.3.3 40.06% <ø> (ø)
2.3.3.4 ?
2.4.0 40.06% <ø> (ø)
2.4.1.3 ?
2.5.1 40.06% <ø> (ø)
2.5.1.2 ?
2.6.0 40.06% <ø> (ø)
2.6.0.2 ?
2.7.0 40.06% <ø> (ø)
2.7.0.0 ?
2.8.0 40.06% <ø> (ø)
2.8.2.2 ?
3.0.1 39.39% <ø> (ø)
3.0.1.0 ?
3.1.0 39.39% <ø> (ø)
3.1.0.0 ?
community 40.06% <ø> (ø)
enterprise ?
integration 40.06% <ø> (-13.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/mtls_auth_service.go 0.00% <0.00%> (-62.50%) ⬇️
kong/vault_service.go 0.00% <0.00%> (-56.67%) ⬇️
kong/developer_service.go 0.00% <0.00%> (-54.87%) ⬇️
kong/rbac_role_service.go 0.00% <0.00%> (-48.94%) ⬇️
kong/developer_role_service.go 0.00% <0.00%> (-46.67%) ⬇️
kong/entity_permission_service.go 0.00% <0.00%> (-40.66%) ⬇️
kong/rbac_user_service.go 0.00% <0.00%> (-34.89%) ⬇️
kong/workspace_service.go 0.00% <0.00%> (-31.33%) ⬇️
kong/types.go 6.66% <0.00%> (-29.34%) ⬇️
kong/endpoint_permission_service.go 0.00% <0.00%> (-26.42%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pmalek
pmalek previously approved these changes Dec 9, 2022
@pmalek pmalek self-requested a review December 9, 2022 08:55
@pmalek pmalek closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants