fix(utils): do not fill empty records #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/default-record-fill
branch
from
5923e9c
to
d8f7e99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 59.92% 59.93%
=======================================
Files 71 71
Lines 4462 4463 +1
=======================================
+ Hits 2674 2675 +1
Misses 1169 1169
Partials 619 619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
follow up of: #466, prevent unset records to be filled with empty tables: {}
samugi
force-pushed
the
fix/default-record-fill
branch
from
d8f7e99
to
ceae801
Compare
Prashansa-K
approved these changes
Sep 12, 2024
pmalek
reviewed
Sep 12, 2024
|
oops, looks like some entries are missing there for the past couple of releases, I think we should open a separate PR to fill those in at once, before releasing, let me know if that sounds good to you @pmalek |
|
Sounds good! Be sure to include the changelog links in the created releases as stated in Lines 5 to 7 in 76af65d |
pmalek
approved these changes
Sep 12, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of: #466, prevent unset records to be filled with empty tables: {}
KAG-5380