feat(ids): prefix all ids and references with a unique string [KHCP-13216] #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
∙ ∙ This should allow utilizing multiple instances of the same icon on a page while preventing reference conflicts and duplicate id selectors.
adamdehaven
requested review from
jillztom,
portikM and
a team
as code owners
adamdehaven
changed the title
adamdehaven
commented
Sep 24, 2024
| @@ -730,6 +730,7 @@ exports[`generate > does not remove icons from the previous build 1`] = ` | |||
| "InsomniaIcon.vue", | |||
| "ItalicIcon.vue", | |||
| "KeyboardReturnIcon.vue", | |||
| "KongGradientIcon.vue", | |||
There was a problem hiding this comment.
I’m not sure why this entry doesn’t already exist on main 🤔 but explains why the open Renovate PRs are failing.
adamdehaven
commented
Sep 24, 2024
adamdehaven
commented
Sep 24, 2024
adamdehaven
commented
Sep 24, 2024
adamdehaven
force-pushed
the
feat/unique-ids
branch
from
600f822 to
6d60e23
Compare
adamdehaven
commented
Sep 24, 2024
adamdehaven
commented
Sep 24, 2024
Justineo
reviewed
Sep 24, 2024
adamdehaven
commented
Sep 24, 2024
Justineo
reviewed
Sep 24, 2024
adamdehaven
commented
Sep 24, 2024
Justineo
reviewed
Sep 25, 2024
vaibhavrajsingh2001
previously approved these changes
Sep 25, 2024
vaibhavrajsingh2001
approved these changes
Sep 25, 2024
kongponents-bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
# [1.16.0](v1.15.2...v1.16.0) (2024-09-25) ### Features * **ids:** prefix all ids and references with a unique string [KHCP-13216] ([#391](#391)) ([9ca7461](9ca7461))
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prefix any internal
idattributes within the SVG with a unique string, and update the corresponding references accordingly to allow utilizing multiple instances of the same icon on a page while preventing reference conflicts and duplicateidselectors.Example
On the
/{geo}/gateway-manager/{control_plane_id}/configurationpage, I can now reference two Azure icons simultaneously with no conflicts from theidattribute(s) or reference(s).Above, notice the prefixed ids