Fix parsing urlencoded pairs with empty values. (#6980)

Kong · Apr 11, 2024 · 0a2187f · 0a2187f
1 parent c562d15
commit 0a2187f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/insomnia/src/utils/importers/importers/curl.test.ts b/packages/insomnia/src/utils/importers/importers/curl.test.ts
@@ -123,7 +123,7 @@ describe('curl', () => {
       { flag: '--data-urlencode', inputs: ['=value'], expected: [{ name: '', value: 'value' }] },
 
       // --data-urlencode URI encoding
-      { flag: '--data-urlencode', inputs: ['a='], expected: [{ name: '', value: 'a=' }] },
+      { flag: '--data-urlencode', inputs: ['a='], expected: [{ name: 'a', value: '' }] },
       { flag: '--data-urlencode', inputs: [' '], expected: [{ name: '', value: ' ' }] },
       { flag: '--data-urlencode', inputs: ['<'], expected: [{ name: '', value: '<' }] },
       { flag: '--data-urlencode', inputs: ['>'], expected: [{ name: '', value: '>' }] },
@@ -133,7 +133,7 @@ describe('curl', () => {
       { flag: '--data-urlencode', inputs: ['|'], expected: [{ name: '', value: '|' }] },
       { flag: '--data-urlencode', inputs: ['^'], expected: [{ name: '', value: '^' }] },
       { flag: '--data-urlencode', inputs: ['"'], expected: [{ name: '', value: '"' }] },
-      { flag: '--data-urlencode', inputs: ['='], expected: [{ name: '', value: '=' }] },
+      { flag: '--data-urlencode', inputs: ['='], expected: [{ name: '', value: '' }] },
       { flag: '--data-urlencode', inputs: ['%3D'], expected: [{ name: '', value: '%3D' }] },
     ])('handles %p correctly', async ({
       flag,

diff --git a/packages/insomnia/src/utils/importers/importers/curl.ts b/packages/insomnia/src/utils/importers/importers/curl.ts
@@ -348,7 +348,7 @@ const pairToParameters = (pair: Pair, allowFiles = false): Parameter[] => {
     }
 
     const [name, value] = pair.split('=');
-    if (!value || !pair.includes('=')) {
+    if (!value && !pair.includes('=')) {
       return { name: '', value: pair };
     }