Prevent modal closing for vim mode #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 To help make this a smooth process, please be sure you have first read the |
gschier
suggested changes
Apr 7, 2019
ernestre
force-pushed
the
prevent-modals-closing-with-vim-editor
branch
from
1638b53
to
a1619b1
Compare
|
Is this ok? |
gschier
approved these changes
Apr 13, 2019
|
Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌 |
|
Thank you ♥ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208 (Currently closed, but the bug still exists)
This fixes the issue regarding the modal closing when
Escapekey is pressed in vim mode. CodeMirror has an eventkeyHandled, which can be used to stop theEscapeevent from closing the modal.https://codemirror.net/doc/manual.html#event_keyHandled