Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC reflection duplicate import error #5525

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Dec 14, 2022

Error: duplicate name '.google.api.http' in Type .google.protobuf.MethodOptions

fixes duplicate import error in upstream protobuf.js by forking latest master and applying the PR fix below.
should be able to remove the fork when protobufjs/protobuf.js#1784 is merged and bumped.

@jackkav jackkav changed the title Chore/remove-protobufjs-override Fix gRPC reflection duplication error Dec 15, 2022
@jackkav jackkav changed the title Fix gRPC reflection duplication error Fix gRPC reflection duplicate import error Dec 15, 2022
@jackkav jackkav marked this pull request as ready for review December 15, 2022 11:36
@jackkav jackkav force-pushed the chore/remove-protobufjs-override branch from 26d9cf5 to ebc30bb Compare December 15, 2022 11:36
@jackkav jackkav enabled auto-merge (squash) December 15, 2022 11:37
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkav jackkav merged commit 59ad93d into Kong:develop Dec 15, 2022
@jackkav jackkav deleted the chore/remove-protobufjs-override branch December 15, 2022 11:54
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Jan 18, 2023
* use fork temporarily

* package lock

* use kong fork of protobuf

* package lock

* re-add proto-loader

* package lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants