Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repeat on interval may lead to stay requesting #6936

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: repeat on interval may lead to stay requesting #6936

merged 1 commit into from
Apr 2, 2024

Conversation

zhengjitf
Copy link
Contributor

@zhengjitf zhengjitf commented Dec 20, 2023 •
edited
Loading

Closes #6891

Two adjustments:

  1. The time interval starts from the end of the previous request.
  2. Send the request immediately upon button click.

@filfreire filfreire self-requested a review March 27, 2024 18:02
filfreire
filfreire approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tested locally following the reproduction steps on #6891 and seems to be working ok now

thank you for contributing this PR!

@filfreire filfreire enabled auto-merge (squash) April 2, 2024 14:17
@filfreire filfreire merged commit c12c4ff into Kong:develop Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The response panel hangs indefinitely when using the Repeat on Interval function
2 participants
@zhengjitf @filfreire