-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hidden-window): enable baseEnvironment in the pre-request scripting [INS-3379] #7102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only has one problem where maybe base environment should not override what we send on the pre-request
insomnia.baseEnvironment.set("testfilipe", "filipe")
pm.collectionVariables.set("testfilipe", "george")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also test environment overrides on the folder level.
If you put a request inside a folder, the folder has an option to add environment overrides that override environment variables
…ment manipulation and overriding
Thank you for comments! The overriding issue is fixed. |
…ing (Kong#7102) * feat(hidden-window): enable baseEnvironment in the pre-request scripting * fix: input empty selected environment data to avoid incorrect environment manipulation and overriding * test: add a test for folder environments overriding * fix: smoke tests failed because of env overriding
Changes: