fix(pre-request script): avoid encoding tags in parsing request urls - INS-3379 #7249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihexxa
changed the title
|
Does this change #7229 need to be reverted? |
|
@CurryYangxx Good catch 👍, updated. |
jackkav
previously approved these changes
Apr 9, 2024
jackkav
approved these changes
Apr 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
In pre-request script execution, originally active request urls will be parsed with URL web API. But in some cases, tags like nunjucks tags would be encoded which would introduce problems in manipulation and sending request.
This change parses urls manually for avoiding this problem.
Changes: