Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(command-palette): Add global search for unsynced files #7405

Merged

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented May 14, 2024

Highlights:

  • Use the new v1/user/files api to fetch remote files
  • Update the command palette to merge remote/local files
  • When selecting a remote file if we already have the TeamProject we pull that file, otherwise redirect to the TeamProject to sync team projects

Conisderations:

  • Project, TeamProject, BackendProject, remoteId, backendProjectId, teamProjectId, project and so on is really hard to reason about. We need to standarize on a common language in the app and api for those things.
  • Test with remote files that exist on projects the user hasn't loaded yet

Closes INS-3666

@gatzjames gatzjames self-assigned this May 14, 2024
@gatzjames gatzjames requested a review from a team May 14, 2024 09:35
@gatzjames gatzjames force-pushed the feat/global-file-search-in-command-palette branch from 2f65245 to 9f5701a Compare May 14, 2024 09:36
@gatzjames gatzjames force-pushed the feat/global-file-search-in-command-palette branch from 818a04c to dda4a7f Compare May 14, 2024 10:01
filfreire
filfreire previously approved these changes May 14, 2024
@gatzjames gatzjames enabled auto-merge (squash) May 14, 2024 13:58
@gatzjames gatzjames merged commit aae0a9c into Kong:develop May 14, 2024
7 checks passed
@gatzjames gatzjames deleted the feat/global-file-search-in-command-palette branch May 14, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants