Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Environment Picker): Simplify the UI #7574

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Jun 21, 2024

Highlights:

  • Collection and Global environments are on the same column
  • There is a new column that displays the active environments in the hierarchy they are applied
image

@gatzjames gatzjames self-assigned this Jun 21, 2024
@gatzjames gatzjames requested a review from a team June 21, 2024 08:51
@gatzjames gatzjames marked this pull request as ready for review June 21, 2024 08:52
jackkav
jackkav previously approved these changes Jun 21, 2024
@jackkav jackkav force-pushed the feat/env-picker-ux-improvements branch from 657b8dd to 4a5bc28 Compare June 21, 2024 10:36
@jackkav jackkav enabled auto-merge (squash) June 21, 2024 10:59
@jackkav jackkav merged commit fbf2b5d into Kong:develop Jun 21, 2024
7 checks passed
Copy link

sentry-io bot commented Jun 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Expected fetch controller: :rp: Array.forEach(<anonymous>) View Issue

Did you find this useful? React with a 👍 or 👎

@AlbinBackstom
Copy link

Is there any way to display the current set environment as it was before? Now it only displays the </> Manage Environments button and its impossible to know what environment you are using without opening the new menu.
image

stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
* update environment picker ui

* remove write from test

---------

Co-authored-by: jackkav <jackkav@gmail.com>
@jonataswalker
Copy link

Please revert this not helpful change.

ihexxa pushed a commit that referenced this pull request Jul 3, 2024
* update environment picker ui

* remove write from test

---------

Co-authored-by: jackkav <jackkav@gmail.com>
@fadelchaidarf
Copy link

Now I have to be extra careful just in case I hit the production environment. Before, I know what environment I'm in just by a glance, the environment color was super nice too

CurryYangxx pushed a commit that referenced this pull request Jul 5, 2024
* update environment picker ui

* remove write from test

---------

Co-authored-by: jackkav <jackkav@gmail.com>
@AlbinBackstom
Copy link

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants