Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file not synced after switch sync method -[INS-4347] #7897

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Sep 2, 2024

Issue detail
Sometimes after switch sync method. The file has become not synced.

Root cause
When using models.xx.update function, sometimes will update model by stale data. After switch to Insomnia Sync, we will delete gitRepositoryId in workspaceMeta and delete the corresponding gitrepository. But the workspaceMeta will be overwritten by the stale data, so there is gitRepositoryId in meta but no
gitrepository data.
image

@CurryYangxx
Copy link
Member Author

I think we need try to use updateByParentId rather than update in most case.

@CurryYangxx CurryYangxx requested a review from a team September 2, 2024 08:56
@jackkav jackkav merged commit 251a350 into develop Sep 2, 2024
7 checks passed
@jackkav jackkav deleted the fix/file-not-synced branch September 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants